fix(frontend): add cooldown tooltips and fix settings tab initial load #50

Open
JustinZeus wants to merge 5 commits from fix/cooldown-tooltip-settings-load into main
JustinZeus commented 2026-03-07 15:46:03 +01:00 (Migrated from github.com)

Summary

  • Cooldown tooltips: Added AppHelpHint tooltip to ScrapeSafetyBadge and ScrapeSafetyBanner explaining what the cooldown is, why it triggered (cooldown_reason_label), and what to do (recommended_action)
  • Settings tab fix: SettingsAdminPanel.vue now defers initial loadSection() via nextTick and uses { flush: "post" } on the section watcher, fixing the race condition where template refs were null on initial navigation
  • Test fix: Updated pdf-queue integration test to expect 200 for non-admin (endpoint now uses get_api_current_user)

Includes cherry-picks from feat/live-scholar-progress-counter:

  • Run/cancel buttons visible to all users
  • Hours interval + PDF queue for all users

Test plan

  • Navigate directly to /settings?tab=users → users list loads immediately
  • Navigate directly to /settings?tab=integrity → integrity checks load
  • Navigate directly to /settings?tab=pdf → pdf queue loads
  • Switch between tabs → content loads correctly
  • Hover ? icon on cooldown badge → tooltip with reason + action
  • When no cooldown → badge tooltip shows "ready" message
  • Run frontend tests (7 new tests pass)

🤖 Generated with Claude Code

## Summary - **Cooldown tooltips**: Added `AppHelpHint` tooltip to `ScrapeSafetyBadge` and `ScrapeSafetyBanner` explaining what the cooldown is, why it triggered (`cooldown_reason_label`), and what to do (`recommended_action`) - **Settings tab fix**: `SettingsAdminPanel.vue` now defers initial `loadSection()` via `nextTick` and uses `{ flush: "post" }` on the section watcher, fixing the race condition where template refs were null on initial navigation - **Test fix**: Updated pdf-queue integration test to expect 200 for non-admin (endpoint now uses `get_api_current_user`) Includes cherry-picks from `feat/live-scholar-progress-counter`: - Run/cancel buttons visible to all users - Hours interval + PDF queue for all users ## Test plan - [ ] Navigate directly to `/settings?tab=users` → users list loads immediately - [ ] Navigate directly to `/settings?tab=integrity` → integrity checks load - [ ] Navigate directly to `/settings?tab=pdf` → pdf queue loads - [ ] Switch between tabs → content loads correctly - [ ] Hover `?` icon on cooldown badge → tooltip with reason + action - [ ] When no cooldown → badge tooltip shows "ready" message - [ ] Run frontend tests (7 new tests pass) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This pull request has changes conflicting with the target branch.
  • frontend/src/features/settings/SettingsAdminPanel.vue
  • frontend/src/pages/SettingsPage.vue
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/cooldown-tooltip-settings-load:fix/cooldown-tooltip-settings-load
git checkout fix/cooldown-tooltip-settings-load

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff fix/cooldown-tooltip-settings-load
git checkout fix/cooldown-tooltip-settings-load
git rebase main
git checkout main
git merge --ff-only fix/cooldown-tooltip-settings-load
git checkout fix/cooldown-tooltip-settings-load
git rebase main
git checkout main
git merge --no-ff fix/cooldown-tooltip-settings-load
git checkout main
git merge --squash fix/cooldown-tooltip-settings-load
git checkout main
git merge --ff-only fix/cooldown-tooltip-settings-load
git checkout main
git merge fix/cooldown-tooltip-settings-load
git push origin main
Sign in to join this conversation.
No description provided.