justinzeus/scholarr
1
0
Fork 0
Code Issues 1 Pull requests 18 Projects Releases Packages Wiki Activity Actions

feat(scholars): add multiselect and bulk actions #49

Open
JustinZeus wants to merge 7 commits from feat/scholar-multiselect-bulk-actions into main
pull from: feat/scholar-multiselect-bulk-actions
merge into: justinzeus:main
Conversation 0 Commits 7 Files changed 16 +7 -5
3 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit ef39ab6a41 - Show all commits

1
app/services/scholars/application.py
View file

@ -27,6 +27,7 @@ from app.services.scholars.validators import (
validate_scholar_id, validate_scholar_id,
) )
async def bulk_delete_scholars( async def bulk_delete_scholars(
db_session: AsyncSession, db_session: AsyncSession,
*, *,

4
frontend/src/features/scholars/index.ts
View file

@ -182,8 +182,8 @@ export async function bulkToggleScholars(scholarProfileIds: number[], isEnabled:
} }
export async function exportScholarData(ids?: number[]): Promise<DataExportPayload> { export async function exportScholarData(ids?: number[]): Promise<DataExportPayload> {
const params = ids && ids.length > 0 ? `?ids=${ids.join(",")}` : ""; const path = ids && ids.length > 0 ? `/scholars/export?ids=${ids.join(",")}` : "/scholars/export";
const response = await apiRequest<DataExportPayload>(`/scholars/export${params}`, { const response = await apiRequest<DataExportPayload>(path, {
method: "GET", method: "GET",
}); });
return response.data; return response.data;

7
tests/integration/test_api_admin.py
View file

@ -340,10 +340,11 @@ async def test_api_admin_dbops_forbidden_for_non_admin_and_validates_scope(db_se
assert forbidden_integrity.status_code == 403 assert forbidden_integrity.status_code == 403
assert forbidden_integrity.json()["error"]["code"] == "forbidden" assert forbidden_integrity.json()["error"]["code"] == "forbidden"
forbidden_pdf_queue = client.get("/api/v1/admin/db/pdf-queue") # PDF queue listing is accessible to all authenticated users (not admin-only).
assert forbidden_pdf_queue.status_code == 403 allowed_pdf_queue = client.get("/api/v1/admin/db/pdf-queue")
assert forbidden_pdf_queue.json()["error"]["code"] == "forbidden" assert allowed_pdf_queue.status_code == 200
# But requeue actions still require admin.
forbidden_requeue = client.post( forbidden_requeue = client.post(
"/api/v1/admin/db/pdf-queue/1/requeue", "/api/v1/admin/db/pdf-queue/1/requeue",
headers=headers, headers=headers,