justinzeus/scholarr
1
0
Fork 0
Code Issues 1 Pull requests 18 Projects Releases Packages Wiki Activity Actions

feat(scholars): add multiselect and bulk actions #49

Open
JustinZeus wants to merge 7 commits from feat/scholar-multiselect-bulk-actions into main
pull from: feat/scholar-multiselect-bulk-actions
merge into: justinzeus:main
Conversation 0 Commits 7 Files changed 16 +788 -130
JustinZeus commented 2026-03-07 14:26:39 +01:00 (Migrated from github.com)
Copy link

Summary

  • Backend: New POST /scholars/bulk-delete, POST /scholars/bulk-toggle endpoints + optional ?ids= filter on export
  • Frontend composable: useScholarBulkActions with Set-based selection, dynamic action menu, confirm dialogs
  • ScholarsPage: Checkbox column (desktop table + mobile cards), select all, bulk action bar with AppSelect dropdown
  • Actions: Bulk delete (with confirm), bulk enable/disable, bulk export (JSON download), clear/select all

Follows existing PublicationsPage multiselect pattern. All endpoints are user-scoped.

Includes cherry-picks from feat/live-scholar-progress-counter:

  • Run/cancel buttons visible to all users
  • Hours interval + PDF queue for all users

Test plan

  • Select multiple scholars → bulk action bar appears with correct count
  • Bulk delete → confirmation → scholars removed, selection cleared
  • Bulk enable/disable → scholars toggled, list updates
  • Bulk export → JSON file with only selected scholars + publications
  • Select all → all scholars selected
  • Run npm run test:run (frontend tests pass)
  • Run ruff check . + ruff format --check . (all pass)
  • Run integration tests for bulk endpoints

🤖 Generated with Claude Code

## Summary - **Backend**: New `POST /scholars/bulk-delete`, `POST /scholars/bulk-toggle` endpoints + optional `?ids=` filter on export - **Frontend composable**: `useScholarBulkActions` with Set-based selection, dynamic action menu, confirm dialogs - **ScholarsPage**: Checkbox column (desktop table + mobile cards), select all, bulk action bar with AppSelect dropdown - **Actions**: Bulk delete (with confirm), bulk enable/disable, bulk export (JSON download), clear/select all Follows existing PublicationsPage multiselect pattern. All endpoints are user-scoped. Includes cherry-picks from `feat/live-scholar-progress-counter`: - Run/cancel buttons visible to all users - Hours interval + PDF queue for all users ## Test plan - [ ] Select multiple scholars → bulk action bar appears with correct count - [ ] Bulk delete → confirmation → scholars removed, selection cleared - [ ] Bulk enable/disable → scholars toggled, list updates - [ ] Bulk export → JSON file with only selected scholars + publications - [ ] Select all → all scholars selected - [ ] Run `npm run test:run` (frontend tests pass) - [ ] Run `ruff check .` + `ruff format --check .` (all pass) - [ ] Run integration tests for bulk endpoints 🤖 Generated with [Claude Code](https://claude.com/claude-code)
This pull request has changes conflicting with the target branch.
  • app/api/routers/scholars.py
  • app/services/scholars/application.py
  • frontend/src/features/scholars/composables/useScholarBulkActions.test.ts
  • frontend/src/features/scholars/composables/useScholarBulkActions.ts
  • frontend/src/features/settings/SettingsAdminPanel.vue
  • frontend/src/pages/SettingsPage.vue
  • tests/integration/test_api_scholars_bulk.py
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin feat/scholar-multiselect-bulk-actions:feat/scholar-multiselect-bulk-actions
git checkout feat/scholar-multiselect-bulk-actions

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main
git merge --no-ff feat/scholar-multiselect-bulk-actions
git checkout feat/scholar-multiselect-bulk-actions
git rebase main
git checkout main
git merge --ff-only feat/scholar-multiselect-bulk-actions
git checkout feat/scholar-multiselect-bulk-actions
git rebase main
git checkout main
git merge --no-ff feat/scholar-multiselect-bulk-actions
git checkout main
git merge --squash feat/scholar-multiselect-bulk-actions
git checkout main
git merge --ff-only feat/scholar-multiselect-bulk-actions
git checkout main
git merge feat/scholar-multiselect-bulk-actions
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
github_actions

Pull requests that update GitHub Actions code

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
python

Pull requests that update python code

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
javascript
python
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: justinzeus/scholarr#49
No description provided.
Delete branch "feat/scholar-multiselect-bulk-actions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?