justinzeus/spreadlab
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

engine: bounds and validation for the new forwarding levers

Browse source 
Novelty, HarmAwareness and ProgramEffect each get a 0..1 realism bound,
served in ConfigBounds and enforced in ValidateConfig with field-named
errors (the frontend matches on the JSON name to flag the right control).
Reject/boundary test cases added.
This commit is contained in:
Justin Visser 2026-06-18 20:07:02 +02:00
parent a0635544d9
commit f21994cc96
2 changed files with 35 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

34
internal/engine/scenario.go
View file

@ -108,10 +108,13 @@ type FloatBounds struct {
// rate. numEducated and origin are relational (0..numStudents and
// 0..numStudents-1) and therefore not listed; seeds are unrestricted.
type Bounds struct {
NumStudents IntBounds `json:"numStudents"`
EdgesPerNode IntBounds `json:"edgesPerNode"`
TriangleProb FloatBounds `json:"triangleProb"`
ForwardProb FloatBounds `json:"forwardProb"`
NumStudents IntBounds `json:"numStudents"`
EdgesPerNode IntBounds `json:"edgesPerNode"`
TriangleProb FloatBounds `json:"triangleProb"`
ForwardProb FloatBounds `json:"forwardProb"`
Novelty FloatBounds `json:"novelty"`
HarmAwareness FloatBounds `json:"harmAwareness"`
ProgramEffect FloatBounds `json:"programEffect"`
}
// ConfigBounds returns the bounds the engine enforces. The frontend
@ -119,10 +122,13 @@ type Bounds struct {
// sliders and clamping from the same numbers.
func ConfigBounds() Bounds {
return Bounds{
NumStudents: IntBounds{Min: 10, Max: 500},
EdgesPerNode: IntBounds{Min: 1, Max: 8},
TriangleProb: FloatBounds{Min: 0, Max: 1},
ForwardProb: FloatBounds{Min: 0, Max: 0.9},
NumStudents: IntBounds{Min: 10, Max: 500},
EdgesPerNode: IntBounds{Min: 1, Max: 8},
TriangleProb: FloatBounds{Min: 0, Max: 1},
ForwardProb: FloatBounds{Min: 0, Max: 0.9},
Novelty: FloatBounds{Min: 0, Max: 1},
HarmAwareness: FloatBounds{Min: 0, Max: 1},
ProgramEffect: FloatBounds{Min: 0, Max: 1},
}
}
@ -147,6 +153,18 @@ func ValidateConfig(config Config) error {
return fmt.Errorf("scenario: need %v <= forwardProb <= %v, got %v",
bounds.ForwardProb.Min, bounds.ForwardProb.Max, config.ForwardProb)
}
if config.Novelty < bounds.Novelty.Min || config.Novelty > bounds.Novelty.Max {
return fmt.Errorf("scenario: need %v <= novelty <= %v, got %v",
bounds.Novelty.Min, bounds.Novelty.Max, config.Novelty)
}
if config.HarmAwareness < bounds.HarmAwareness.Min || config.HarmAwareness > bounds.HarmAwareness.Max {
return fmt.Errorf("scenario: need %v <= harmAwareness <= %v, got %v",
bounds.HarmAwareness.Min, bounds.HarmAwareness.Max, config.HarmAwareness)
}
if config.ProgramEffect < bounds.ProgramEffect.Min || config.ProgramEffect > bounds.ProgramEffect.Max {
return fmt.Errorf("scenario: need %v <= programEffect <= %v, got %v",
bounds.ProgramEffect.Min, bounds.ProgramEffect.Max, config.ProgramEffect)
}
if config.NumEducated < 0 || config.NumEducated > config.NumStudents {
return fmt.Errorf("scenario: need 0 <= numEducated <= %d students, got %d",
config.NumStudents, config.NumEducated)