Justin Visser
bf04c77aa9
Add ruff and mypy to dev dependencies with configuration in pyproject.toml. Add a lint CI job that runs ruff check, ruff format --check, and mypy. Auto-fix import sorting and formatting across the codebase. Exclude alembic/versions from linting (auto-generated migrations). Ignore B008 (FastAPI Depends pattern) and RUF001 (unicode in user-facing strings). 21 ruff lint errors and 50 mypy errors remain for manual review. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
45 lines
1.7 KiB
Python
45 lines
1.7 KiB
Python
from __future__ import annotations
|
|
|
|
from datetime import UTC, datetime
|
|
|
|
from app.services.domains.ingestion import scheduler as scheduler_module
|
|
from app.services.domains.ingestion.application import ScholarIngestionService
|
|
from app.settings import settings
|
|
|
|
|
|
def _set_policy_minimum(value: int) -> int:
|
|
previous = int(settings.ingestion_min_request_delay_seconds)
|
|
object.__setattr__(settings, "ingestion_min_request_delay_seconds", int(value))
|
|
return previous
|
|
|
|
|
|
def test_ingestion_effective_request_delay_respects_policy_minimum() -> None:
|
|
previous = _set_policy_minimum(8)
|
|
try:
|
|
assert ScholarIngestionService._effective_request_delay_seconds(7) == 8
|
|
assert ScholarIngestionService._effective_request_delay_seconds(12) == 12
|
|
finally:
|
|
object.__setattr__(settings, "ingestion_min_request_delay_seconds", previous)
|
|
|
|
|
|
def test_scheduler_effective_request_delay_respects_policy_minimum() -> None:
|
|
previous = _set_policy_minimum(9)
|
|
try:
|
|
assert scheduler_module._effective_request_delay_seconds(None) == 9
|
|
assert scheduler_module._effective_request_delay_seconds(6) == 9
|
|
assert scheduler_module._effective_request_delay_seconds(11) == 11
|
|
finally:
|
|
object.__setattr__(settings, "ingestion_min_request_delay_seconds", previous)
|
|
|
|
|
|
def test_scheduler_candidate_row_clamps_request_delay() -> None:
|
|
previous = _set_policy_minimum(6)
|
|
try:
|
|
candidate = scheduler_module.SchedulerService._candidate_from_row(
|
|
(1, 15, 1, None, None),
|
|
now_utc=datetime(2026, 2, 21, tzinfo=UTC),
|
|
)
|
|
assert candidate is not None
|
|
assert candidate.request_delay_seconds == 6
|
|
finally:
|
|
object.__setattr__(settings, "ingestion_min_request_delay_seconds", previous)
|