scholarr/tests/unit/test_request_delay_policy.py
Justin Visser 3fd9132176 refactor: fix naming, remove duplicate code from decomposition
- Rename _int_or_default → int_or_default (public API, was using private convention)
- Extract shared pdf_queue utilities (utcnow, event_row, queued_job, status constants) to pdf_queue_common.py to avoid circular imports
- Consolidate _effective_request_delay_seconds into queue_runner.py with explicit floor parameter
- Update tests to match new function locations and names

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-27 16:07:24 +01:00

46 lines
1.8 KiB
Python

from __future__ import annotations
from datetime import UTC, datetime
from app.services.ingestion import scheduler as scheduler_module
from app.services.ingestion.application import ScholarIngestionService
from app.services.ingestion.queue_runner import effective_request_delay_seconds
from app.settings import settings
def _set_policy_minimum(value: int) -> int:
previous = int(settings.ingestion_min_request_delay_seconds)
object.__setattr__(settings, "ingestion_min_request_delay_seconds", int(value))
return previous
def test_ingestion_effective_request_delay_respects_policy_minimum() -> None:
previous = _set_policy_minimum(8)
try:
assert ScholarIngestionService._effective_request_delay_seconds(7) == 8
assert ScholarIngestionService._effective_request_delay_seconds(12) == 12
finally:
object.__setattr__(settings, "ingestion_min_request_delay_seconds", previous)
def test_scheduler_effective_request_delay_respects_policy_minimum() -> None:
previous = _set_policy_minimum(9)
try:
assert effective_request_delay_seconds(None, floor=9) == 9
assert effective_request_delay_seconds(6, floor=9) == 9
assert effective_request_delay_seconds(11, floor=9) == 11
finally:
object.__setattr__(settings, "ingestion_min_request_delay_seconds", previous)
def test_scheduler_candidate_row_clamps_request_delay() -> None:
previous = _set_policy_minimum(6)
try:
candidate = scheduler_module.SchedulerService._candidate_from_row(
(1, 15, 1, None, None),
now_utc=datetime(2026, 2, 21, tzinfo=UTC),
)
assert candidate is not None
assert candidate.request_delay_seconds == 6
finally:
object.__setattr__(settings, "ingestion_min_request_delay_seconds", previous)