justinzeus/scholarr
1
0
Fork 0
Code Issues 1 Pull requests 18 Projects Releases Packages Wiki Activity Actions

fix: align test assertion with rollback behavior #40

Merged
JustinZeus merged 1 commit from mypi-fix into main 2026-03-01 23:18:05 +01:00
Conversation 0 Commits 1 Files changed 1 +2 -2
JustinZeus commented 2026-03-01 23:17:58 +01:00 (Migrated from github.com)
Copy link

The upsert rolls back the entire transaction on partial failure, so new_pub_count and link count should be consistent (both 0), not assuming the first publication survived.

The upsert rolls back the entire transaction on partial failure, so new_pub_count and link count should be consistent (both 0), not assuming the first publication survived.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
dependencies

Pull requests that update a dependency file

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
github_actions

Pull requests that update GitHub Actions code

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
javascript

Pull requests that update javascript code

  
python

Pull requests that update python code

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
dependencies
documentation
duplicate
enhancement
github_actions
good first issue
help wanted
invalid
javascript
python
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: justinzeus/scholarr#40
No description provided.
Delete branch "mypi-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?