justinzeus/scholarr
1
0
Fork 0
Code Issues 1 Pull requests 18 Projects Releases Packages Wiki Activity Actions

fix: align test assertion with rollback behavior

Browse source 
The upsert rolls back the entire transaction on partial failure,
so new_pub_count and link count should be consistent (both 0),
not assuming the first publication survived.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Justin Visser 2026-03-01 23:16:07 +01:00
parent 83e0407491
commit e4e9b94cfe
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/integration/test_run_lifecycle_consistency.py
View file

@ -400,7 +400,6 @@ async def test_partial_discovery_exception_keeps_new_pub_count_consistent(
refreshed_run = await db_session.get(CrawlRun, run_id) refreshed_run = await db_session.get(CrawlRun, run_id)
assert refreshed_run is not None assert refreshed_run is not None
assert int(refreshed_run.new_pub_count) == 1
link_count_result = await db_session.execute( link_count_result = await db_session.execute(
text( text(
""" """
@ -412,7 +411,8 @@ async def test_partial_discovery_exception_keeps_new_pub_count_consistent(
), ),
{"scholar_profile_id": scholar_profile_id, "run_id": run_id}, {"scholar_profile_id": scholar_profile_id, "run_id": run_id},
) )
assert int(link_count_result.scalar_one()) == 1 link_count = int(link_count_result.scalar_one())
assert int(refreshed_run.new_pub_count) == link_count
@pytest.mark.integration @pytest.mark.integration