Big changes

app/services/domains/publications/read_state.py

@@ -16,16 +16,20 @@ def _normalized_selection_pairs(selections: list[tuple[int, int]]) -> set[tuple[
     return pairs
 
 
+def _scoped_scholar_ids_query(*, user_id: int):
+    return (
+        select(ScholarProfile.id)
+        .where(ScholarProfile.user_id == user_id)
+        .scalar_subquery()
+    )
+
+
 async def mark_all_unread_as_read_for_user(
     db_session: AsyncSession,
     *,
     user_id: int,
 ) -> int:
-    scholar_ids = (
-        select(ScholarProfile.id)
-        .where(ScholarProfile.user_id == user_id)
-        .scalar_subquery()
-    )
+    scholar_ids = _scoped_scholar_ids_query(user_id=user_id)
     stmt = (
         update(ScholarPublication)
         .where(
@@ -49,11 +53,7 @@ async def mark_selected_as_read_for_user(
     if not normalized_pairs:
         return 0
 
-    scholar_ids = (
-        select(ScholarProfile.id)
-        .where(ScholarProfile.user_id == user_id)
-        .scalar_subquery()
-    )
+    scholar_ids = _scoped_scholar_ids_query(user_id=user_id)
     stmt = (
         update(ScholarPublication)
         .where(
@@ -69,3 +69,26 @@ async def mark_selected_as_read_for_user(
     result = await db_session.execute(stmt)
     await db_session.commit()
     return int(result.rowcount or 0)
+
+
+async def set_publication_favorite_for_user(
+    db_session: AsyncSession,
+    *,
+    user_id: int,
+    scholar_profile_id: int,
+    publication_id: int,
+    is_favorite: bool,
+) -> int:
+    scholar_ids = _scoped_scholar_ids_query(user_id=user_id)
+    stmt = (
+        update(ScholarPublication)
+        .where(
+            ScholarPublication.scholar_profile_id.in_(scholar_ids),
+            ScholarPublication.scholar_profile_id == int(scholar_profile_id),
+            ScholarPublication.publication_id == int(publication_id),
+        )
+        .values(is_favorite=bool(is_favorite))
+    )
+    result = await db_session.execute(stmt)
+    await db_session.commit()
+    return int(result.rowcount or 0)