justinzeus/scholarr
1
0
Fork 0
Code Issues 1 Pull requests 18 Projects Releases Packages Wiki Activity Actions

ci: add ruff linting and mypy type checking

Browse source 
Add ruff and mypy to dev dependencies with configuration in pyproject.toml.
Add a lint CI job that runs ruff check, ruff format --check, and mypy.
Auto-fix import sorting and formatting across the codebase. Exclude
alembic/versions from linting (auto-generated migrations). Ignore B008
(FastAPI Depends pattern) and RUF001 (unicode in user-facing strings).

21 ruff lint errors and 50 mypy errors remain for manual review.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Justin Visser 2026-02-26 22:11:41 +01:00
parent 399276ea69
commit bf04c77aa9
137 changed files with 3066 additions and 1900 deletions
Download patch file Download diff file Expand all files Collapse all files

32
app/api/routers/admin.py
View file

@ -86,7 +86,14 @@ async def create_user(
message=str(exc),
) from exc
structured_log(logger, "info", "api.admin.user_created", admin_user_id=int(admin_user.id), target_user_id=int(created_user.id), target_is_admin=bool(created_user.is_admin))
structured_log(
logger,
"info",
"api.admin.user_created",
admin_user_id=int(admin_user.id),
target_user_id=int(created_user.id),
target_is_admin=bool(created_user.is_admin),
)
return success_payload(
request,
data=_serialize_user(created_user),
@ -111,11 +118,7 @@ async def set_user_active(
code="user_not_found",
message="User not found.",
)
if (
int(target_user.id) == int(admin_user.id)
and bool(target_user.is_active)
and not bool(payload.is_active)
):
if int(target_user.id) == int(admin_user.id) and bool(target_user.is_active) and not bool(payload.is_active):
raise ApiException(
status_code=400,
code="cannot_deactivate_self",
@ -126,7 +129,14 @@ async def set_user_active(
user=target_user,
is_active=bool(payload.is_active),
)
structured_log(logger, "info", "api.admin.user_active_updated", admin_user_id=int(admin_user.id), target_user_id=int(updated_user.id), is_active=bool(updated_user.is_active))
structured_log(
logger,
"info",
"api.admin.user_active_updated",
admin_user_id=int(admin_user.id),
target_user_id=int(updated_user.id),
is_active=bool(updated_user.is_active),
)
return success_payload(
request,
data=_serialize_user(updated_user),
@ -166,7 +176,13 @@ async def reset_user_password(
user=target_user,
password_hash=auth_service.hash_password(validated_password),
)
structured_log(logger, "info", "api.admin.user_password_reset", admin_user_id=int(admin_user.id), target_user_id=int(target_user.id))
structured_log(
logger,
"info",
"api.admin.user_password_reset",
admin_user_id=int(admin_user.id),
target_user_id=int(target_user.id),
)
return success_payload(
request,
data={"message": f"Password reset: {target_user.email}"},