From afbb25d2178ce99d6659ef90ff9d35a2e2900bd7 Mon Sep 17 00:00:00 2001
From: Justin Visser <justinfvisser@gmail.com>
Date: Sat, 7 Mar 2026 15:32:22 +0100
Subject: [PATCH] fix(ci): use theme tokens for badges, update pdf-queue test

- Replace raw dark: utility variants with state-* theme tokens
  in ScholarStatusBadges and ScholarSettingsModal
- Update integration test to expect 200 for pdf-queue listing
  (endpoint now uses get_api_current_user, not admin-only)
---
 .../features/scholars/components/ScholarSettingsModal.vue | 2 +-
 .../features/scholars/components/ScholarStatusBadges.vue  | 8 ++++----
 tests/integration/test_api_admin.py                       | 7 ++++---
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/frontend/src/features/scholars/components/ScholarSettingsModal.vue b/frontend/src/features/scholars/components/ScholarSettingsModal.vue
index 511bf66..77af0ac 100644
--- a/frontend/src/features/scholars/components/ScholarSettingsModal.vue
+++ b/frontend/src/features/scholars/components/ScholarSettingsModal.vue
@@ -51,7 +51,7 @@ function scholarPublicationsRoute(profile: ScholarProfile): { name: string; quer
             {{ scholarLabel(scholar) }}
             <span
               v-if="!scholar.baseline_completed"
-              class="ml-1.5 inline-flex items-center rounded-full bg-amber-50 px-1.5 py-0.5 text-[10px] font-medium text-amber-700 ring-1 ring-inset ring-amber-600/20 dark:bg-amber-950 dark:text-amber-400 dark:ring-amber-400/20"
+              class="ml-1.5 inline-flex items-center rounded-full border border-state-warning-border bg-state-warning-bg px-1.5 py-0.5 text-[10px] font-medium text-state-warning-text"
               title="This scholar hasn't been scraped yet. Publications will appear after the next run."
             >Pending</span>
           </p>
diff --git a/frontend/src/features/scholars/components/ScholarStatusBadges.vue b/frontend/src/features/scholars/components/ScholarStatusBadges.vue
index 5460658..86b2cd5 100644
--- a/frontend/src/features/scholars/components/ScholarStatusBadges.vue
+++ b/frontend/src/features/scholars/components/ScholarStatusBadges.vue
@@ -8,22 +8,22 @@ defineProps<{
 <template>
   <span
     v-if="!baselineCompleted"
-    class="ml-1.5 inline-flex items-center rounded-full bg-amber-50 px-1.5 py-0.5 text-[10px] font-medium text-amber-700 ring-1 ring-inset ring-amber-600/20 dark:bg-amber-950 dark:text-amber-400 dark:ring-amber-400/20"
+    class="ml-1.5 inline-flex items-center rounded-full border border-state-warning-border bg-state-warning-bg px-1.5 py-0.5 text-[10px] font-medium text-state-warning-text"
     title="This scholar hasn't been scraped yet. Publications will appear after the next run."
   >Pending</span>
   <span
     v-if="lastRunStatus === 'failed'"
-    class="ml-1.5 inline-flex items-center rounded-full bg-red-50 px-1.5 py-0.5 text-[10px] font-medium text-red-700 ring-1 ring-inset ring-red-600/20 dark:bg-red-950 dark:text-red-400 dark:ring-red-400/20"
+    class="ml-1.5 inline-flex items-center rounded-full border border-state-danger-border bg-state-danger-bg px-1.5 py-0.5 text-[10px] font-medium text-state-danger-text"
     title="The last scrape run for this scholar failed."
   >Failed</span>
   <span
     v-else-if="lastRunStatus === 'partial'"
-    class="ml-1.5 inline-flex items-center rounded-full bg-amber-50 px-1.5 py-0.5 text-[10px] font-medium text-amber-700 ring-1 ring-inset ring-amber-600/20 dark:bg-amber-950 dark:text-amber-400 dark:ring-amber-400/20"
+    class="ml-1.5 inline-flex items-center rounded-full border border-state-warning-border bg-state-warning-bg px-1.5 py-0.5 text-[10px] font-medium text-state-warning-text"
     title="The last scrape run for this scholar completed with partial results."
   >Partial</span>
   <span
     v-else-if="lastRunStatus === 'success'"
-    class="ml-1.5 inline-flex items-center rounded-full bg-green-50 px-1.5 py-0.5 text-[10px] font-medium text-green-700 ring-1 ring-inset ring-green-600/20 dark:bg-green-950 dark:text-green-400 dark:ring-green-400/20"
+    class="ml-1.5 inline-flex items-center rounded-full border border-state-success-border bg-state-success-bg px-1.5 py-0.5 text-[10px] font-medium text-state-success-text"
     title="The last scrape run for this scholar completed successfully."
   >OK</span>
 </template>
diff --git a/tests/integration/test_api_admin.py b/tests/integration/test_api_admin.py
index fb63f34..f80a8e3 100644
--- a/tests/integration/test_api_admin.py
+++ b/tests/integration/test_api_admin.py
@@ -340,10 +340,11 @@ async def test_api_admin_dbops_forbidden_for_non_admin_and_validates_scope(db_se
     assert forbidden_integrity.status_code == 403
     assert forbidden_integrity.json()["error"]["code"] == "forbidden"
 
-    forbidden_pdf_queue = client.get("/api/v1/admin/db/pdf-queue")
-    assert forbidden_pdf_queue.status_code == 403
-    assert forbidden_pdf_queue.json()["error"]["code"] == "forbidden"
+    # PDF queue listing is accessible to all authenticated users (not admin-only).
+    allowed_pdf_queue = client.get("/api/v1/admin/db/pdf-queue")
+    assert allowed_pdf_queue.status_code == 200
 
+    # But requeue actions still require admin.
     forbidden_requeue = client.post(
         "/api/v1/admin/db/pdf-queue/1/requeue",
         headers=headers,