fix: resolve remaining ruff lint and mypy type errors

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

app/services/domains/publications/__init__.py

@@ -1 +1,84 @@
-from app.services.domains.publications.application import *
+from app.services.domains.publications.application import (
+    MODE_ALL as MODE_ALL,
+)
+from app.services.domains.publications.application import (
+    MODE_LATEST as MODE_LATEST,
+)
+from app.services.domains.publications.application import (
+    MODE_NEW as MODE_NEW,
+)
+from app.services.domains.publications.application import (
+    MODE_UNREAD as MODE_UNREAD,
+)
+from app.services.domains.publications.application import (
+    PublicationListItem as PublicationListItem,
+)
+from app.services.domains.publications.application import (
+    UnreadPublicationItem as UnreadPublicationItem,
+)
+from app.services.domains.publications.application import (
+    count_favorite_for_user as count_favorite_for_user,
+)
+from app.services.domains.publications.application import (
+    count_for_user as count_for_user,
+)
+from app.services.domains.publications.application import (
+    count_latest_for_user as count_latest_for_user,
+)
+from app.services.domains.publications.application import (
+    count_pdf_queue_items as count_pdf_queue_items,
+)
+from app.services.domains.publications.application import (
+    count_unread_for_user as count_unread_for_user,
+)
+from app.services.domains.publications.application import (
+    enqueue_all_missing_pdf_jobs as enqueue_all_missing_pdf_jobs,
+)
+from app.services.domains.publications.application import (
+    enqueue_retry_pdf_job_for_publication_id as enqueue_retry_pdf_job_for_publication_id,
+)
+from app.services.domains.publications.application import (
+    get_latest_run_id_for_user as get_latest_run_id_for_user,
+)
+from app.services.domains.publications.application import (
+    get_publication_item_for_user as get_publication_item_for_user,
+)
+from app.services.domains.publications.application import (
+    hydrate_pdf_enrichment_state as hydrate_pdf_enrichment_state,
+)
+from app.services.domains.publications.application import (
+    list_for_user as list_for_user,
+)
+from app.services.domains.publications.application import (
+    list_pdf_queue_items as list_pdf_queue_items,
+)
+from app.services.domains.publications.application import (
+    list_pdf_queue_page as list_pdf_queue_page,
+)
+from app.services.domains.publications.application import (
+    list_unread_for_user as list_unread_for_user,
+)
+from app.services.domains.publications.application import (
+    mark_all_unread_as_read_for_user as mark_all_unread_as_read_for_user,
+)
+from app.services.domains.publications.application import (
+    mark_selected_as_read_for_user as mark_selected_as_read_for_user,
+)
+from app.services.domains.publications.application import (
+    publications_query as publications_query,
+)
+from app.services.domains.publications.application import (
+    resolve_publication_view_mode as resolve_publication_view_mode,
+)
+from app.services.domains.publications.application import (
+    retry_pdf_for_user as retry_pdf_for_user,
+)
+from app.services.domains.publications.application import (
+    schedule_missing_pdf_enrichment_for_user as schedule_missing_pdf_enrichment_for_user,
+)
+from app.services.domains.publications.application import (
+    schedule_retry_pdf_enrichment_for_row as schedule_retry_pdf_enrichment_for_row,
+)
+from app.services.domains.publications.application import (
+    set_publication_favorite_for_user as set_publication_favorite_for_user,
+)

app/services/domains/publications/pdf_queue.py

@@ -190,12 +190,10 @@ def _can_enqueue_job(
         return False
     if int(job.attempt_count) >= _auto_retry_max_attempts():
         return False
-    if _cooldown_active(
+    return not _cooldown_active(
         last_attempt_at=job.last_attempt_at,
         attempt_count=int(job.attempt_count),
-    ):
-        return False
-    return True
+    )
 
 
 def _event_row(

app/services/domains/publications/pdf_resolution_pipeline.py

@@ -5,7 +5,7 @@ from dataclasses import dataclass
 from typing import Any
 
 from app.logging_utils import structured_log
-from app.services.domains.arxiv.application import ArxivRateLimitError
+from app.services.domains.arxiv.errors import ArxivRateLimitError
 from app.services.domains.arxiv.guards import arxiv_skip_reason_for_item
 from app.services.domains.openalex.client import OpenAlexBudgetExhaustedError
 from app.services.domains.publications.types import PublicationListItem

app/services/domains/publications/queries.py

@@ -19,7 +19,7 @@ from app.services.domains.publications.types import PublicationListItem, UnreadP
 
 def _normalized_citation_count(value: object) -> int:
     try:
-        return int(value or 0)
+        return int(value or 0)  # type: ignore[call-overload]  # intentionally accepts any object
     except (TypeError, ValueError):
         return 0