fix(scholars): improve validation, fix delete, add status badges

- Extract scholar ID parsing to dedicated module with robust URL
  handling (trailing slashes, fragments, extra query params, encoded
  characters) and per-token error feedback showing why each invalid
  entry was skipped
- Wrap delete_scholar DB commit in IntegrityError handler so cascade
  failures return a proper API error instead of 500
- Add ScholarStatusBadges component showing Pending/Failed/Partial/OK
  badges on scholar rows based on baseline_completed and last_run_status
- Show Pending badge in ScholarSettingsModal for unscraped scholars
- Surface failed_count and partial_count in dashboard latest run summary
  and recent run list items
- Extend backend validator tests with edge cases (empty, whitespace,
  unicode, URL-as-ID)
- Add integration tests for DELETE 404, DELETE with cascade, and POST
  with corrupted scholar_id
- Add comprehensive frontend tests for parsing logic and component
  behavior

frontend/src/features/scholars/components/ScholarBatchAdd.test.ts

@@ -2,10 +2,144 @@
 import { describe, expect, it } from "vitest";
 import { mount } from "@vue/test-utils";
 import ScholarBatchAdd from "./ScholarBatchAdd.vue";
+import {
+  parseScholarIds,
+  parseScholarTokens,
+  extractScholarIdFromUrl,
+  validateTokenAsId,
+} from "./scholar-batch-parsing";
 
 const defaultProps = { saving: false, loading: false };
 
-describe("ScholarBatchAdd", () => {
+describe("parseScholarIds (unit)", () => {
+  it("parses a single bare ID", () => {
+    expect(parseScholarIds("A-UbBTPM15wL")).toEqual(["A-UbBTPM15wL"]);
+  });
+
+  it("parses multiple IDs separated by commas", () => {
+    expect(parseScholarIds("A-UbBTPM15wL, B-UbBTPM15wL")).toEqual(["A-UbBTPM15wL", "B-UbBTPM15wL"]);
+  });
+
+  it("deduplicates IDs", () => {
+    expect(parseScholarIds("A-UbBTPM15wL\nA-UbBTPM15wL")).toEqual(["A-UbBTPM15wL"]);
+  });
+
+  it("extracts ID from standard Google Scholar URL", () => {
+    expect(parseScholarIds("https://scholar.google.com/citations?hl=en&user=A-UbBTPM15wL")).toEqual(["A-UbBTPM15wL"]);
+  });
+
+  it("extracts ID from URL with trailing slash", () => {
+    expect(parseScholarIds("https://scholar.google.com/citations?user=A-UbBTPM15wL/")).toEqual(["A-UbBTPM15wL"]);
+  });
+
+  it("extracts ID from URL with fragment", () => {
+    expect(parseScholarIds("https://scholar.google.com/citations?user=A-UbBTPM15wL#section")).toEqual(["A-UbBTPM15wL"]);
+  });
+
+  it("extracts ID from URL with extra query params", () => {
+    expect(parseScholarIds("https://scholar.google.com/citations?hl=en&user=A-UbBTPM15wL&view_op=list_works&sortby=pubdate")).toEqual(["A-UbBTPM15wL"]);
+  });
+
+  it("handles URL-encoded characters in non-ID parts", () => {
+    expect(parseScholarIds("https://scholar.google.com/citations?hl=en&user=A-UbBTPM15wL&label=%E4%B8%AD%E6%96%87")).toEqual(["A-UbBTPM15wL"]);
+  });
+
+  it("rejects malformed IDs (too short)", () => {
+    expect(parseScholarIds("ABC123")).toEqual([]);
+  });
+
+  it("rejects malformed IDs (too long)", () => {
+    expect(parseScholarIds("ABCDEF1234567")).toEqual([]);
+  });
+
+  it("rejects IDs with special characters", () => {
+    expect(parseScholarIds("ABCDEF12345!")).toEqual([]);
+  });
+
+  it("rejects IDs with embedded whitespace", () => {
+    expect(parseScholarIds("ABC DEF12345")).toEqual([]);
+  });
+
+  it("handles mixed valid and invalid tokens", () => {
+    expect(parseScholarIds("A-UbBTPM15wL, invalid, B-UbBTPM15wL")).toEqual(["A-UbBTPM15wL", "B-UbBTPM15wL"]);
+  });
+
+  it("returns empty array for empty string", () => {
+    expect(parseScholarIds("")).toEqual([]);
+  });
+
+  it("returns empty array for whitespace only", () => {
+    expect(parseScholarIds("   ")).toEqual([]);
+  });
+});
+
+describe("extractScholarIdFromUrl", () => {
+  it("returns null for non-URL strings", () => {
+    expect(extractScholarIdFromUrl("not-a-url")).toBeNull();
+  });
+
+  it("returns null for URL without user param", () => {
+    expect(extractScholarIdFromUrl("https://scholar.google.com/citations?hl=en")).toBeNull();
+  });
+
+  it("extracts from URL with trailing slashes", () => {
+    expect(extractScholarIdFromUrl("https://scholar.google.com/citations?user=A-UbBTPM15wL///")).toBe("A-UbBTPM15wL");
+  });
+
+  it("strips fragment before parsing", () => {
+    expect(extractScholarIdFromUrl("https://scholar.google.com/citations?user=A-UbBTPM15wL#foo")).toBe("A-UbBTPM15wL");
+  });
+
+  it("returns null when user param is invalid length", () => {
+    expect(extractScholarIdFromUrl("https://scholar.google.com/citations?user=short")).toBeNull();
+  });
+});
+
+describe("validateTokenAsId", () => {
+  it("returns null for valid 12-char ID", () => {
+    expect(validateTokenAsId("ABCDEF123456")).toBeNull();
+  });
+
+  it("detects wrong length", () => {
+    expect(validateTokenAsId("ABC")).toContain("12 characters");
+  });
+
+  it("detects invalid characters", () => {
+    expect(validateTokenAsId("ABCDEF12345!")).toContain("invalid characters");
+  });
+
+  it("detects whitespace", () => {
+    expect(validateTokenAsId("ABC DEF12345")).toContain("whitespace");
+  });
+
+  it("detects empty input", () => {
+    expect(validateTokenAsId("")).toContain("empty");
+  });
+});
+
+describe("parseScholarTokens (per-token errors)", () => {
+  it("marks invalid tokens with error messages", () => {
+    const tokens = parseScholarTokens("A-UbBTPM15wL, short, B-UbBTPM15wL");
+    expect(tokens).toHaveLength(3);
+    expect(tokens[0].id).toBe("A-UbBTPM15wL");
+    expect(tokens[0].error).toBeNull();
+    expect(tokens[1].id).toBeNull();
+    expect(tokens[1].error).toContain("12 characters");
+    expect(tokens[2].id).toBe("B-UbBTPM15wL");
+  });
+
+  it("marks duplicate tokens", () => {
+    const tokens = parseScholarTokens("A-UbBTPM15wL, A-UbBTPM15wL");
+    expect(tokens[1].error).toBe("duplicate");
+  });
+
+  it("marks bad URL tokens", () => {
+    const tokens = parseScholarTokens("https://scholar.google.com/citations?hl=en");
+    expect(tokens[0].error).toContain("could not extract");
+  });
+});
+
+describe("ScholarBatchAdd (component)", () => {
   it("renders the heading and input", () => {
     const wrapper = mount(ScholarBatchAdd, { props: defaultProps });
     expect(wrapper.text()).toContain("Add Scholar Profiles");
@@ -73,4 +207,18 @@ describe("ScholarBatchAdd", () => {
     const wrapper = mount(ScholarBatchAdd, { props: { ...defaultProps, saving: true } });
     expect(wrapper.text()).toContain("Adding...");
   });
+
+  it("shows validation errors for invalid tokens", async () => {
+    const wrapper = mount(ScholarBatchAdd, { props: defaultProps });
+    await wrapper.find("textarea").setValue("A-UbBTPM15wL, bad!");
+    const errors = wrapper.find("[data-testid='validation-errors']");
+    expect(errors.exists()).toBe(true);
+  });
+
+  it("shows skipped count alongside valid count", async () => {
+    const wrapper = mount(ScholarBatchAdd, { props: defaultProps });
+    await wrapper.find("textarea").setValue("A-UbBTPM15wL, tooshort");
+    expect(wrapper.text()).toContain("1 valid");
+    expect(wrapper.text()).toContain("1 skipped");
+  });
 });