Add option to play item forcing transcoding (#153)

Closes #97 

Adds an option to force an item to play by transcoding. This can be
useful in the few cases where the device reports that it supports direct
play for a file, but it really doesn't.

Also rearranges the "More" dialog list to move picking audio & subtitle
track near the top.

app/src/main/java/com/github/damontecres/wholphin/ui/detail/DetailUtils.kt

@@ -65,53 +65,7 @@ fun buildMoreDialogItems(
                 )
             },
         )
-        add(
-            DialogItem(
-                text = if (watched) R.string.mark_unwatched else R.string.mark_watched,
-                iconStringRes = if (watched) R.string.fa_eye else R.string.fa_eye_slash,
-            ) {
-                onClickWatch.invoke(!watched)
-            },
-        )
-        add(
-            DialogItem(
-                text = if (favorite) R.string.remove_favorite else R.string.add_favorite,
-                iconStringRes = R.string.fa_heart,
-                iconColor = if (favorite) Color.Red else Color.Unspecified,
-            ) {
-                onClickFavorite.invoke(!favorite)
-            },
-        )
-        series?.let {
-            add(
-                DialogItem(
-                    context.getString(R.string.go_to_series),
-                    Icons.AutoMirrored.Filled.ArrowForward,
-                ) {
-                    navigateTo(
-                        Destination.MediaItem(
-                            series.id,
-                            BaseItemKind.SERIES,
-                            series,
-                        ),
-                    )
-                },
-            )
-        }
         item.data.mediaSources?.letNotEmpty { sources ->
-            if (sources.size > 1) {
-                add(
-                    DialogItem(
-                        context.getString(
-                            R.string.choose_stream,
-                            context.getString(R.string.version),
-                        ),
-                        R.string.fa_file_video,
-                    ) {
-                        onChooseVersion.invoke()
-                    },
-                )
-            }
             val source =
                 sourceId?.let { sources.firstOrNull { it.id?.toUUIDOrNull() == sourceId } }
                     ?: sources.firstOrNull()
@@ -145,7 +99,68 @@ fun buildMoreDialogItems(
                     )
                 }
             }
+            if (sources.size > 1) {
+                add(
+                    DialogItem(
+                        context.getString(
+                            R.string.choose_stream,
+                            context.getString(R.string.version),
+                        ),
+                        R.string.fa_file_video,
+                    ) {
+                        onChooseVersion.invoke()
+                    },
+                )
+            }
         }
+        add(
+            DialogItem(
+                text = if (watched) R.string.mark_unwatched else R.string.mark_watched,
+                iconStringRes = if (watched) R.string.fa_eye else R.string.fa_eye_slash,
+            ) {
+                onClickWatch.invoke(!watched)
+            },
+        )
+        add(
+            DialogItem(
+                text = if (favorite) R.string.remove_favorite else R.string.add_favorite,
+                iconStringRes = R.string.fa_heart,
+                iconColor = if (favorite) Color.Red else Color.Unspecified,
+            ) {
+                onClickFavorite.invoke(!favorite)
+            },
+        )
+        series?.let {
+            add(
+                DialogItem(
+                    context.getString(R.string.go_to_series),
+                    Icons.AutoMirrored.Filled.ArrowForward,
+                ) {
+                    navigateTo(
+                        Destination.MediaItem(
+                            series.id,
+                            BaseItemKind.SERIES,
+                            series,
+                        ),
+                    )
+                },
+            )
+        }
+        add(
+            DialogItem(
+                context.getString(R.string.play_with_transcoding),
+                Icons.Default.PlayArrow,
+            ) {
+                navigateTo(
+                    Destination.Playback(
+                        item.id,
+                        item.resumeMs ?: 0L,
+                        item,
+                        forceTranscoding = true,
+                    ),
+                )
+            },
+        )
     }
 
 fun buildMoreDialogItemsForHome(

app/src/main/java/com/github/damontecres/wholphin/ui/nav/Destination.kt

@@ -73,6 +73,7 @@ sealed class Destination(
         val startIndex: Int? = null,
         val shuffle: Boolean = false,
         val itemPlayback: ItemPlayback? = null,
+        val forceTranscoding: Boolean = false,
     ) : Destination(true) {
         override fun toString(): String = "Playback(itemId=$itemId, positionMs=$positionMs)"
 

app/src/main/java/com/github/damontecres/wholphin/ui/playback/PlaybackViewModel.kt

@@ -209,6 +209,11 @@ class PlaybackViewModel
                                 destination.startIndex,
                                 destination.shuffle,
                             )
+                        if (playlist.items.isEmpty()) {
+                            showToast(context, "Playlist is empty", Toast.LENGTH_SHORT)
+                            navigationManager.goBack()
+                            return@launch
+                        }
                         withContext(Dispatchers.Main) {
                             this@PlaybackViewModel.playlist.value = playlist
                         }
@@ -218,7 +223,13 @@ class PlaybackViewModel
                         queriedItem
                     }
 
-                val played = play(base, destination.positionMs, destination.itemPlayback)
+                val played =
+                    play(
+                        base,
+                        destination.positionMs,
+                        destination.itemPlayback,
+                        destination.forceTranscoding,
+                    )
                 if (!played) {
                     playUpNextUp()
                 }
@@ -238,6 +249,7 @@ class PlaybackViewModel
             base: BaseItemDto,
             positionMs: Long,
             itemPlayback: ItemPlayback? = null,
+            forceTranscoding: Boolean = false,
         ): Boolean =
             withContext(Dispatchers.IO) {
                 Timber.i("Playing ${base.id}")
@@ -369,6 +381,8 @@ class PlaybackViewModel
                         subtitleIndex,
                         if (positionMs > 0) positionMs else C.TIME_UNSET,
                         itemPlayback != null, // If it was passed in, then it was not queried from the database
+                        enableDirectPlay = !forceTranscoding,
+                        enableDirectStream = !forceTranscoding,
                     )
                     player.prepare()
 

app/src/main/java/com/github/damontecres/wholphin/ui/setup/SwitchUserViewModel.kt

@@ -75,6 +75,13 @@ class SwitchUserViewModel
 
         fun init() {
             viewModelScope.launchIO {
+                quickConnectJob?.cancel()
+                withContext(Dispatchers.Main) {
+                    users.value = listOf()
+                    serverStatus.value = mapOf()
+                    serverQuickConnect.value = mapOf()
+                }
+
                 val allServers =
                     serverDao
                         .getServers()

app/src/main/res/values/strings.xml

@@ -137,6 +137,7 @@
     <string name="video">Video</string>
     <string name="watch_live">Watch live</string>
     <string name="years_old">%1$d years old</string>
+    <string name="play_with_transcoding">Play with transcoding</string>
 
     <plurals name="downloads">
         <item quantity="zero">%d downloads</item>