From c82d36794f2dd6019ab1be1ddee28feacefac657 Mon Sep 17 00:00:00 2001 From: JustinZeus <33318938+JustinZeus@users.noreply.github.com> Date: Thu, 21 May 2026 18:43:49 +0200 Subject: [PATCH] Fix bottom padding in playback controls (#1422) Fixes #1396. The else branch of `when (nextState)` in PlaybackController added a 32dp Spacer that left empty space below the controls when there were no chapters or queue. Possible follow-up: Pentaphon's idea of a "similar items" row in that empty slot. Happy to put up a separate PR if useful. ## Testing Verified on an Android TV (1080p) AVD running API 34 by playing a movie with no chapters and no next-up item. With the fix, the bottom of the control overlay sits the expected 8dp from the screen edge (the existing parent padding). Also rebuilt without the fix and compared back-to-back to confirm the Spacer was the cause. The CHAPTERS and QUEUE branches were not modified. ## Screenshot case1-controls ## AI or LLM usage I used Claude to help identify the file containing the bug and to suggest the fix. I reviewed the diff before committing. --- .../wholphin/ui/playback/overlay/PlaybackController.kt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/app/src/main/java/com/github/damontecres/wholphin/ui/playback/overlay/PlaybackController.kt b/app/src/main/java/com/github/damontecres/wholphin/ui/playback/overlay/PlaybackController.kt index 0de48d15..528b6546 100644 --- a/app/src/main/java/com/github/damontecres/wholphin/ui/playback/overlay/PlaybackController.kt +++ b/app/src/main/java/com/github/damontecres/wholphin/ui/playback/overlay/PlaybackController.kt @@ -10,9 +10,7 @@ import androidx.compose.foundation.interaction.collectIsFocusedAsState import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Column import androidx.compose.foundation.layout.Row -import androidx.compose.foundation.layout.Spacer import androidx.compose.foundation.layout.fillMaxWidth -import androidx.compose.foundation.layout.height import androidx.compose.foundation.layout.offset import androidx.compose.foundation.layout.padding import androidx.compose.runtime.Composable @@ -117,7 +115,7 @@ fun PlaybackController( } else -> { - Spacer(Modifier.height(32.dp)) + Unit } } }