justinzeus/Wholphin
1
0
Fork 0
mirror of https://github.com/JustinZeus/Wholphin.git synced 2026-07-08 23:51:21 +02:00
Code Issues Projects Packages Wiki Activity Actions

Fix(player): Disable gpu-next by default (#760)

Browse source 
## Description
Disables gpu-next by default in MPV settings. This renderer is
experimental and causes broken playback (purple screen) on some older
devices like the NVIDIA Shield 2019 Pro.

Also adds a migration to ensure gpu-next is turned off for existing
users who upgrade, avoiding playback regressions for users being newly
moved over to the Prefer MPV settings so that they can experience a
smooth transition.

### Related issues
Fixes #754?

### Screenshots
N/A

### AI/LLM usage
PR drafting
This commit is contained in:
Justin Caveda 2026-01-24 18:24:23 -06:00 • committed by GitHub
parent 47e54aa675
commit 7b8f5c3e63
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/com/github/damontecres/wholphin/preferences/AppPreference.kt
View file

@ -783,7 +783,7 @@ sealed interface AppPreference<Pref, T> {
val MpvGpuNext = val MpvGpuNext =
AppSwitchPreference<AppPreferences>( AppSwitchPreference<AppPreferences>(
title = R.string.mpv_use_gpu_next, title = R.string.mpv_use_gpu_next,
defaultValue = true, defaultValue = false,
getter = { it.playbackPreferences.mpvOptions.useGpuNext }, getter = { it.playbackPreferences.mpvOptions.useGpuNext },
setter = { prefs, value -> setter = { prefs, value ->
prefs.updateMpvOptions { useGpuNext = value } prefs.updateMpvOptions { useGpuNext = value }

8
app/src/main/java/com/github/damontecres/wholphin/services/AppUpgradeHandler.kt
View file

@ -209,4 +209,12 @@ suspend fun upgradeApp(
} }
showToast(context, context.getString(R.string.upgrade_mpv_toast), Toast.LENGTH_LONG) showToast(context, context.getString(R.string.upgrade_mpv_toast), Toast.LENGTH_LONG)
} }
if (previous.isEqualOrBefore(Version.fromString("0.4.0-2-g0"))) {
appPreferences.updateData {
it.updateMpvOptions {
useGpuNext = false
}
}
}
} }