From 792d3598b784766b03569f15b100d8b89d0511b5 Mon Sep 17 00:00:00 2001
From: Ray <154766448+damontecres@users.noreply.github.com>
Date: Thu, 29 Jan 2026 13:31:51 -0500
Subject: [PATCH] Fix a few discover UI bugs (#795)

## Description
Just fixes a couple small UI issues on the discover/seerr pages
---
 .../java/com/github/damontecres/wholphin/ui/Extensions.kt  | 3 +--
 .../ui/detail/discover/DiscoverMovieDetailsHeader.kt       | 7 +++++--
 .../damontecres/wholphin/ui/nav/DestinationContent.kt      | 1 +
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/app/src/main/java/com/github/damontecres/wholphin/ui/Extensions.kt b/app/src/main/java/com/github/damontecres/wholphin/ui/Extensions.kt
index 4dbb0870..12854cd7 100644
--- a/app/src/main/java/com/github/damontecres/wholphin/ui/Extensions.kt
+++ b/app/src/main/java/com/github/damontecres/wholphin/ui/Extensions.kt
@@ -56,7 +56,6 @@ import kotlin.contracts.contract
 import kotlin.coroutines.CoroutineContext
 import kotlin.math.min
 import kotlin.time.Duration
-import kotlin.time.Duration.Companion.milliseconds
 import kotlin.time.Duration.Companion.minutes
 import kotlin.time.Duration.Companion.seconds
 
@@ -234,7 +233,7 @@ val Duration.roundMinutes: Duration
  * Rounds a [Duration] to nearest whole second
  */
 val Duration.roundSeconds: Duration
-    get() = (this + 30.milliseconds).inWholeSeconds.seconds
+    get() = (this + .5.seconds).inWholeSeconds.seconds
 
 /**
  * Gets the user's playback position as a [Duration]
diff --git a/app/src/main/java/com/github/damontecres/wholphin/ui/detail/discover/DiscoverMovieDetailsHeader.kt b/app/src/main/java/com/github/damontecres/wholphin/ui/detail/discover/DiscoverMovieDetailsHeader.kt
index 4da6f938..79ccb8dd 100644
--- a/app/src/main/java/com/github/damontecres/wholphin/ui/detail/discover/DiscoverMovieDetailsHeader.kt
+++ b/app/src/main/java/com/github/damontecres/wholphin/ui/detail/discover/DiscoverMovieDetailsHeader.kt
@@ -25,6 +25,7 @@ import com.github.damontecres.wholphin.preferences.UserPreferences
 import com.github.damontecres.wholphin.ui.components.GenreText
 import com.github.damontecres.wholphin.ui.components.OverviewText
 import com.github.damontecres.wholphin.ui.components.QuickDetails
+import com.github.damontecres.wholphin.ui.isNotNullOrBlank
 import com.github.damontecres.wholphin.ui.letNotEmpty
 import com.github.damontecres.wholphin.ui.listToDotString
 import com.github.damontecres.wholphin.ui.roundMinutes
@@ -103,7 +104,8 @@ fun DiscoverMovieDetailsHeader(
                 GenreText(it, Modifier.padding(bottom = padding))
             }
 
-            movie.tagline?.let { tagline ->
+            val tagline = remember { movie.tagline?.takeIf { it.isNotNullOrBlank() } }
+            tagline?.let {
                 Text(
                     text = tagline,
                     style = MaterialTheme.typography.bodyLarge,
@@ -134,8 +136,9 @@ fun DiscoverMovieDetailsHeader(
                 remember(movie.credits?.crew) {
                     movie.credits
                         ?.crew
-                        ?.filter { it.job == "Directing" }
+                        ?.filter { it.job == "Director" && it.name.isNotNullOrBlank() }
                         ?.joinToString(", ") { it.name!! }
+                        ?.takeIf { it.isNotNullOrBlank() }
                 }
 
             directorName
diff --git a/app/src/main/java/com/github/damontecres/wholphin/ui/nav/DestinationContent.kt b/app/src/main/java/com/github/damontecres/wholphin/ui/nav/DestinationContent.kt
index 43b8841d..70ef71d2 100644
--- a/app/src/main/java/com/github/damontecres/wholphin/ui/nav/DestinationContent.kt
+++ b/app/src/main/java/com/github/damontecres/wholphin/ui/nav/DestinationContent.kt
@@ -279,6 +279,7 @@ fun DestinationContent(
                 }
 
                 SeerrItemType.PERSON -> {
+                    LaunchedEffect(Unit) { onClearBackdrop.invoke() }
                     DiscoverPersonPage(
                         person = destination.item,
                         modifier = modifier,